From: Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: kvm: make --mem-path memory allocation depend on mmu notifiers
Date: Tue, 13 Jan 2009 14:38:33 -0600 [thread overview]
Message-ID: <496CFBC9.6040006@codemonkey.ws> (raw)
In-Reply-To: <20090113203617.GA8671@amt.cnet>
Marcelo Tosatti wrote:
> Without mmu notifiers usage of hugepages to back guest memory can cause
> memory corruption.
>
Really? Why's that? Sorry if I missed a previous discussion of this.
Regards,
Anthony Liguori
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
>
> diff --git a/qemu/vl.c b/qemu/vl.c
> index d0660ab..49cf066 100644
> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -4664,6 +4664,11 @@ void *alloc_mem_area(size_t memory, unsigned long *len, const char *path)
> void *area;
> int fd;
>
> + if (!kvm_has_sync_mmu()) {
> + fprintf(stderr, "host lacks mmu notifiers, disabling --mem-path\n");
> + return NULL;
> + }
> +
> if (asprintf(&filename, "%s/kvm.XXXXXX", path) == -1)
> return NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-01-13 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 20:36 kvm: make --mem-path memory allocation depend on mmu notifiers Marcelo Tosatti
2009-01-13 20:38 ` Anthony Liguori [this message]
2009-01-13 20:50 ` Marcelo Tosatti
2009-01-13 20:57 ` David S. Ahern
2009-01-14 0:07 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496CFBC9.6040006@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox