From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Fix typos and whitespace errors Date: Wed, 14 Jan 2009 16:55:40 +0200 Message-ID: <496DFCEC.7080509@redhat.com> References: <1231843674-11333-1-git-send-email-amit.shah@redhat.com> <1231843674-11333-2-git-send-email-amit.shah@redhat.com> <20090113105305.GB28504@amit-x200.pnq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38332 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762831AbZANOzn (ORCPT ); Wed, 14 Jan 2009 09:55:43 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0EEthAf022445 for ; Wed, 14 Jan 2009 09:55:43 -0500 In-Reply-To: <20090113105305.GB28504@amit-x200.pnq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: >> -#define KVM_CPUID_FLAG_SIGNIFCANT_INDEX 1 >> -#define KVM_CPUID_FLAG_STATEFUL_FUNC 2 >> -#define KVM_CPUID_FLAG_STATE_READ_NEXT 4 >> +#define KVM_CPUID_FLAG_SIGNIFICANT_INDEX 1 >> > > Avi, this is assuming we can push this fix to the stable kernel series. > Can that be done or should we live with the typo? (Or adding a > #define KVM_CPUID_FLAG_SIGNIFICANT_INDEX KVM_CPUID_FLAG_SIGNIFCANT_INDEX > ?) > I think we can live with the typo. We have enough compatibility headaches. -- error compiling committee.c: too many arguments to function