From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] kvm: libkvm: support for irq routing Date: Thu, 15 Jan 2009 11:59:43 +0200 Message-ID: <496F090F.4050805@redhat.com> References: <1231941191-966-1-git-send-email-avi@redhat.com> <1231941191-966-2-git-send-email-avi@redhat.com> <200901151417.17178.sheng@linux.intel.com> <200901151420.39324.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55436 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922AbZAOJ7q (ORCPT ); Thu, 15 Jan 2009 04:59:46 -0500 In-Reply-To: <200901151420.39324.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > On Thursday 15 January 2009 14:17:16 Sheng Yang wrote: > >> On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote: >> >>> Signed-off-by: Avi Kivity >>> >> Do we need a lock for the table? >> > > And kvm_add_irq_route/kvm_del_irq_route should be generic used, how about > transfer a kvm_irq_routing_entry as parameter? > These structures + selectors + unions are clumsy. For libkvm, I'd prefer adding kvm_add_msi() and kvm_del_msi(). -- error compiling committee.c: too many arguments to function