From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init() Date: Thu, 15 Jan 2009 15:58:08 +0200 Message-ID: <496F40F0.7090502@redhat.com> References: <1232027262-21487-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43758 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757097AbZAON6M (ORCPT ); Thu, 15 Jan 2009 08:58:12 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0FDwBmQ008241 for ; Thu, 15 Jan 2009 08:58:11 -0500 In-Reply-To: <1232027262-21487-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > NIC init functions don't return a PCIDevice pointer in upstream QEMU > but they do in KVM for hotplug. > > Fixes: > > qemu/hw/pci.c:740: warning: initialization from incompatible pointer type > > I should have caught this while merging, argh. Applied all patches except #10, thanks. If qemu gains a --developer option which enables -Werror (and if we're warning clean), I promise to use it. -- error compiling committee.c: too many arguments to function