From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing Date: Thu, 15 Jan 2009 16:35:21 +0200 Message-ID: <496F49A9.7040305@redhat.com> References: <1232027262-21487-1-git-send-email-markmc@redhat.com> <1232027262-21487-2-git-send-email-markmc@redhat.com> <1232027262-21487-3-git-send-email-markmc@redhat.com> <1232027262-21487-4-git-send-email-markmc@redhat.com> <1232027262-21487-5-git-send-email-markmc@redhat.com> <1232027262-21487-6-git-send-email-markmc@redhat.com> <1232027262-21487-7-git-send-email-markmc@redhat.com> <1232027262-21487-8-git-send-email-markmc@redhat.com> <1232027262-21487-9-git-send-email-markmc@redhat.com> <1232027262-21487-10-git-send-email-markmc@redhat.com> <496F4017.5020603@redhat.com> <1232029458.5205.21.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59041 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754967AbZAOOfZ (ORCPT ); Thu, 15 Jan 2009 09:35:25 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0FEZNtV016513 for ; Thu, 15 Jan 2009 09:35:23 -0500 In-Reply-To: <1232029458.5205.21.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: >> Why drop _rom? The memory region is registered as a rom, a few lines >> earlier? >> > > My mistake, can you just apply the change to the first line? > > Sure, applied with _rom. -- error compiling committee.c: too many arguments to function