From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Avoid using CONFIG_ in userspace visible headers Date: Mon, 19 Jan 2009 15:12:36 +0200 Message-ID: <49747C44.1030901@redhat.com> References: <1232370050-7434-1-git-send-email-avi@redhat.com> <20090119130927.GC6876@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sam Ravnborg , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Ingo Molnar Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48564 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760107AbZASNMp (ORCPT ); Mon, 19 Jan 2009 08:12:45 -0500 In-Reply-To: <20090119130927.GC6876@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: Ingo Molnar wrote: > * Avi Kivity wrote: > > >> Kconfig symbols are not available in userspace, and are not stripped by >> headers-install. Avoid their use by adding #defines in to >> suit each architecture. >> >> > looks good - you will push this via the KVM tree, right? > Yes. Thanks for the review. -- error compiling committee.c: too many arguments to function