From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/7] qemu:virtio-net: Add MAC and VLAN filtering Date: Mon, 19 Jan 2009 20:27:12 -0600 Message-ID: <49753680.8060301@codemonkey.ws> References: <20090116210954.16725.44321.stgit@kvm.aw> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, markmc@redhat.com, Rusty Russell To: Alex Williamson Return-path: Received: from yx-out-2324.google.com ([74.125.44.28]:40377 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759AbZATC1Z (ORCPT ); Mon, 19 Jan 2009 21:27:25 -0500 Received: by yx-out-2324.google.com with SMTP id 8so1406064yxm.1 for ; Mon, 19 Jan 2009 18:27:24 -0800 (PST) In-Reply-To: <20090116210954.16725.44321.stgit@kvm.aw> Sender: kvm-owner@vger.kernel.org List-ID: Any comments Rusty? I'm waiting for input on the kernel bits to apply the QEMU side of this. Regards, Anthony Liguori Alex Williamson wrote: > This series adds the ability for the guest to set the virtio-net device > MAC address, a new control virtqueue for setting configuration data from > the guest, and new interfaces making use of the control virtqueue for > setting RX mode options, MAC filter table entries, and VLAN filter bits. > The end result is that the virtio-net device has more of the features of > a realy hardware NIC and can be configured to drop packets the guest > isn't interested in seeing. > > This version incorporates the review comments from Mark McLoughlin, > particularly including much better commit logs, factoring control > commands into separate functions, and making a local ETH_ALEN define. > Also new in this version is the addition of VLAN filtering. Please > comment and/or apply. Thanks, > > Alex > > Note - This series depends on the previous patch sent to correct > save and load of the virtio-net state. > --- > > Alex Williamson (7): > qemu:virtio-net: Add VLAN filtering > qemu:virtio-net: Add additional MACs via a filter table > qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti > qemu:virtio-net: Add promiscuous and all-multicast mode bits > qemu:virtio-net: Add a virtqueue for control commands from the guest > qemu:virtio-net: Define ETH_ALEN for use when manipulating MAC addresses > qemu:virtio-net: Allow setting the MAC address via set_config > > > qemu/hw/virtio-net.c | 280 +++++++++++++++++++++++++++++++++++++++++++++++++- > qemu/hw/virtio-net.h | 61 +++++++++++ > 2 files changed, 333 insertions(+), 8 deletions(-) > >