Re: [PATCH] Always return latest pmsts instead of the old one.

[Anthony Liguori <aliguori@us.ibm.com>]

Zhang, Xiantao wrote:
> Attached the new patch, please check.
> Xiantao
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Subject: Always return latest pmsts instead of the old one.
>
> It may lead to the issue when booting windows guests with acpi=1
> if return the old pmsts.
>
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
>
> Modified Paths:
> --------------
>     trunk/hw/acpi.c
>
> Modified: trunk/hw/acpi.c
> ===================================================================
>
> --- trunk/hw/acpi.c
> +++ trunk/hw/acpi.c
> @@ -92,7 +92,7 @@ static int get_pmsts(PIIX4PMState *s)
>      d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
>      if (d >= s->tmr_overflow_time)
>          s->pmsts |= TMROF_EN;
> -    return pmsts;
> +    return s->pmsts;
>  }
>  
>  static void pm_update_sci(PIIX4PMState *s)
>
>
>
> Anthony Liguori wrote:
>   
>> Zhang, Xiantao wrote:
>>     
>>> For get_pmsts of acpi, it should always return latest value instead
>>> of the old one. Xiantao 
>>>
>>>
>>> From: Xiantao Zhang <xiantao.zhang@intel.com>
>>> Date: Tue, 13 Jan 2009 17:42:16 +0800
>>> Subject: [PATCH] Always return latest pmsts instead of the old one.
>>>
>>> It may lead to the issue when booting windows guests with acpi=1
>>> if return the old pmsts.
>>>
>>> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com> ---
>>>  qemu/hw/acpi.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
>>>
>>>       
>> Please resubmit against QEMU, not kvm-userspace.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>     
>>> index 0ff8851..8bde989 100644
>>> --- a/qemu/hw/acpi.c
>>> +++ b/qemu/hw/acpi.c
>>> @@ -94,7 +94,7 @@ static int get_pmsts(PIIX4PMState *s)
>>>      d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
>>>      if (d >= s->tmr_overflow_time)
>>>          s->pmsts |= TMROF_EN;
>>> -    return pmsts;
>>> +    return s->pmsts;
>>>  }
>>>
>>>  static void pm_update_sci(PIIX4PMState *s)
>>>       
>
>