From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] kvm-s390: Fix printk on SIGP set arch Date: Thu, 22 Jan 2009 13:58:57 +0200 Message-ID: <49785F81.3030704@redhat.com> References: <200901221026.13261.borntraeger@de.ibm.com> <200901221027.38992.borntraeger@de.ibm.com> <20090122121707.2dffd96b@osiris.boeblingen.de.ibm.com> <20090122122611.28ceddd2@cotte.boeblingen.de.ibm.com> <20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Carsten Otte , heicars2@linux.vnet.ibm.com, borntrae@linux.vnet.ibm.com, kvm@vger.kernel.org, Christian Ehrhardt , Olaf Schnapper To: Heiko Carstens Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60936 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859AbZAVL7E (ORCPT ); Thu, 22 Jan 2009 06:59:04 -0500 In-Reply-To: <20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Heiko Carstens wrote: > On Thu, 22 Jan 2009 12:26:11 +0100 > Carsten Otte wrote: > > >> Am Thu, 22 Jan 2009 12:17:07 +0100 >> schrieb heicars2@linux.vnet.ibm.com: >> >>> Why don't you just remove the printk? IMHO it's rather pointless. >>> >> It is'nt: It infoms the user why his guest is going to crash >> even though it has performed an operation that is perfectly >> legal according to the spec. >> > > If you have hundreds of guests running, how do you get the connection > from this message to a specific user process? > > Informing a user process that it did something that isn't allowed or > supported is usually done by returning an appropriate return code. > Right, either inject an exception to the guest (if appropriate for the arch), or return -ESOMETHING from ioctl(KVM_RUN). -- error compiling committee.c: too many arguments to function