Re: [PATCH] Fix almost infinite loop in APIC

Marcelo Tosatti
2009-01-21T16:55:51Z

On Wed, Jan 21, 2009 at 05:18:00PM +0100, Alexander Graf wrote:
> Marcelo Tosatti wrote:
> > On Wed, Jan 21, 2009 at 01:11:23PM +0800, Sheng Yang wrote:
> >
> >> Use ktime_to_ns() macro is better.
> >>
> >> The remaining parts are fine with me. But please do more test. :)
> >>
> >> Thanks for work!
> >>
> >
> > Alexander, can you please confirm this works for you, thanks.
> >
>
> Looks good so far. I can't really tell if it's doing the right thing,
> but at least it's not crashing the host anymore ;). And the VM does come
> up (somewhat).

What might be going wrong there is if there are accumulated interrupts
to be injected (pending > 0). You might want to check that in
apic_get_tmcct.

> Signed-off-by: Alexander Graf <agraf@suse.de>

Thanks