From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3 v2] kvm-s390: Fix printk on SIGP set arch Date: Thu, 22 Jan 2009 16:23:56 +0200 Message-ID: <4978817C.8030408@redhat.com> References: <200901221026.13261.borntraeger@de.ibm.com> <20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com> <49785F81.3030704@redhat.com> <200901221420.27403.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Heiko Carstens , Carsten Otte , heicars2@linux.vnet.ibm.com, borntrae@linux.vnet.ibm.com, kvm@vger.kernel.org, Christian Ehrhardt , Olaf Schnapper To: Christian Borntraeger Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39484 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325AbZAVOZL (ORCPT ); Thu, 22 Jan 2009 09:25:11 -0500 In-Reply-To: <200901221420.27403.borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Christian Borntraeger wrote: > Am Thursday 22 January 2009 12:58:57 schrieb Avi Kivity: > >> Right, either inject an exception to the guest (if appropriate for the >> arch), or return -ESOMETHING from ioctl(KVM_RUN). >> > > Ok. What about: > > [PATCH] kvm-s390: fix printk on SIGP set arch > > From: Christian Borntraeger > Reported-by: Heiko Carstens > > KVM on s390 does not support the ESA/390 architecture. We refuse to > change the architecture mode and print a warning. This patch removes > the printk for several reasons: > > o A malicious can flood host dmesg > o The old message had no newline > o there is no connection between the message and the failing guest > > This patch simply removes the printk. We already set the condition > code to 3 - the guest knows that something went wrong. > Applied (with the other patches), thanks. Please include a printk() patch in every s390 patchset so people can participate in the review and discussion. -- error compiling committee.c: too many arguments to function