From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] report IRQ injection status to userspace. Date: Mon, 02 Feb 2009 16:04:55 +0200 Message-ID: <4986FD87.2030404@redhat.com> References: <20090121113227.GH27675@redhat.com> <20090121123428.GI27675@redhat.com> <20090126161038.GB3894@amt.cnet> <20090127132739.GG15778@redhat.com> <20090127154107.GC5806@amt.cnet> <20090128163735.GI15778@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60751 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbZBBOE7 (ORCPT ); Mon, 2 Feb 2009 09:04:59 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n12E4w1h006989 for ; Mon, 2 Feb 2009 09:04:58 -0500 In-Reply-To: <20090128163735.GI15778@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: >> Right, I was thinking about >> >> if (irq >= 0 && irq < IOAPIC_NUM_PINS) { >> >> Should return MASKED if irq is outside the acceptable range? >> >> > Is this ever can be false? Should we BUG() if irq is out of range? > > Yes, the number ultimately comes from userspace. -- error compiling committee.c: too many arguments to function