From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: more about serial ports: do they even work?
Date: Wed, 04 Feb 2009 11:37:14 +0300
Message-ID: <498953BA.7060407@msgid.tls.msk.ru>
References: <497E1B15.2090908@msgid.tls.msk.ru> <497E1F7D.90300@msgid.tls.msk.ru> <49876547.1080904@cisco.com> <49876678.4090808@msgid.tls.msk.ru> <4987674E.9050201@cisco.com> <4987FCBA.7020104@msgid.tls.msk.ru> <4988032A.5010905@ntlworld.com> <20090204080942.GA3640@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Mark Marshall <mark.marshall60@ntlworld.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"David S. Ahern" <daahern@cisco.com>,
	KVM list <kvm@vger.kernel.org>, qemu-devel@nongnu.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from isrv.corpit.ru ([81.13.33.159]:38695 "EHLO isrv.corpit.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751599AbZBDIhT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Feb 2009 03:37:19 -0500
In-Reply-To: <20090204080942.GA3640@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> On Tue, Feb 03, 2009 at 08:41:14AM +0000, Mark Marshall wrote:
[]
> Right. I don't understand the point of converting to an "internal"
> representation of TIOCM control bits. 

<fun mode>
Well, the same goes for the IOCTL values themselves too -- like
this CHR_IOCTL_SERIAL_SET_TIOCM itself.  I mean, TIOCMSET is
the right name for it ;)  But see below.

> CHR_IOCTL_SERIAL_SET_TIOCM is clearly broken as mentioned. It should at 
> least preserve the bits it does not control.
> 
> diff --git a/qemu/qemu-char.c b/qemu/qemu-char.c
> index ac431c7..66971e1 100644
> --- a/qemu/qemu-char.c
> +++ b/qemu/qemu-char.c
> @@ -1063,33 +1063,12 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
>          break;
>      case CHR_IOCTL_SERIAL_GET_TIOCM:
>          {
> +            ioctl(s->fd_in, TIOCMGET, arg);
>          }
>          break;

And those parens too, let it die, die! ;)
</fun mode>

Other than that, an.. excellent idea, I wanted to propose
just that when I first saw all this stuff, but was somewhat
afraid.  And I *think* there's at least *some* sense.  Qemu
is a CPU emulator and may work on another arch where those
bits are defined differently.  Maybe that was the reason for
all this converting - to be safe than sorry, so to say.  No?

/mjt