From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: more about serial ports: do they even work? Date: Wed, 04 Feb 2009 11:09:34 +0000 Message-ID: <4989776E.1060504@eu.citrix.com> References: <497E1B15.2090908@msgid.tls.msk.ru> <497E1F7D.90300@msgid.tls.msk.ru> <49876547.1080904@cisco.com> <49876678.4090808@msgid.tls.msk.ru> <4987674E.9050201@cisco.com> <4987FCBA.7020104@msgid.tls.msk.ru> <4988032A.5010905@ntlworld.com> <20090204080942.GA3640@amt.cnet> <498953BA.7060407@msgid.tls.msk.ru> Reply-To: qemu-devel@nongnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Marcelo Tosatti , "David S. Ahern" , Mark Marshall , KVM list To: Michael Tokarev Return-path: In-Reply-To: <498953BA.7060407@msgid.tls.msk.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Michael Tokarev wrote: > Other than that, an.. excellent idea, I wanted to propose > just that when I first saw all this stuff, but was somewhat > afraid. And I *think* there's at least *some* sense. Qemu > is a CPU emulator and may work on another arch where those > bits are defined differently. Maybe that was the reason for > all this converting - to be safe than sorry, so to say. No? > Yes, this is exactly the reason why they were introduced in the first place. Let's suppose that the guest defines those constants differently: we need to parse them and covert them appropriately to the host format. CHR_IOCTL_SERIAL_SET_TIOCM and CHR_TIOCM_DTR correspond to the guest version of TIOCMSET and TIOCM_DTR and can be defined differently depending on the particular guest arch.