From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix GPE registers read/write handling.
Date: Wed, 04 Feb 2009 14:46:28 +0200 [thread overview]
Message-ID: <49898E24.2030003@redhat.com> (raw)
In-Reply-To: <20090204123957.GF30234@redhat.com>
Gleb Natapov wrote:
>> It's strange that write_val() and reset_val() return a value. Won't it
>> be cleaner to make val a pointer?
>>
>>
> From functional programing POV no, it is not cleaner. But I don't really
> care where to do assignment.
>
We're not doing functional programming:
a = f(a, x)
is just duplication, but still has an assignment.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-02-04 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 9:58 [PATCH 1/3] Fix GPE registers read/write handling Gleb Natapov
2009-02-04 9:58 ` [PATCH 2/3] Fix CPU hotplug Gleb Natapov
2009-02-04 12:45 ` Avi Kivity
2009-02-04 13:03 ` Gleb Natapov
2009-02-04 13:24 ` Avi Kivity
2009-02-04 13:31 ` Gleb Natapov
2009-02-04 13:35 ` Avi Kivity
2009-02-04 13:36 ` Gleb Natapov
2009-02-04 9:58 ` [PATCH 3/3] PCI hotplug fixes Gleb Natapov
2009-02-04 12:29 ` [PATCH 1/3] Fix GPE registers read/write handling Avi Kivity
2009-02-04 12:39 ` Gleb Natapov
2009-02-04 12:46 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49898E24.2030003@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox