From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] Fix GPE registers read/write handling. Date: Wed, 04 Feb 2009 14:46:28 +0200 Message-ID: <49898E24.2030003@redhat.com> References: <20090204095805.6892.47195.stgit@dhcp-1-237.tlv.redhat.com> <49898A13.8030706@redhat.com> <20090204123957.GF30234@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53288 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755634AbZBDMqa (ORCPT ); Wed, 4 Feb 2009 07:46:30 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n14CkUDC031224 for ; Wed, 4 Feb 2009 07:46:30 -0500 In-Reply-To: <20090204123957.GF30234@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: >> It's strange that write_val() and reset_val() return a value. Won't it >> be cleaner to make val a pointer? >> >> > From functional programing POV no, it is not cleaner. But I don't really > care where to do assignment. > We're not doing functional programming: a = f(a, x) is just duplication, but still has an assignment. -- error compiling committee.c: too many arguments to function