From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] Fix CPU hotplug Date: Wed, 04 Feb 2009 15:24:59 +0200 Message-ID: <4989972B.2090609@redhat.com> References: <20090204095805.6892.47195.stgit@dhcp-1-237.tlv.redhat.com> <20090204095810.6892.59110.stgit@dhcp-1-237.tlv.redhat.com> <49898DD8.1020609@redhat.com> <20090204130323.GG30234@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56291 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757248AbZBDNZB (ORCPT ); Wed, 4 Feb 2009 08:25:01 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n14DP1a9005942 for ; Wed, 4 Feb 2009 08:25:01 -0500 In-Reply-To: <20090204130323.GG30234@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: >>> struct pci_status { >>> @@ -603,10 +603,12 @@ static uint32_t gpe_readb(void *opaque, uint32_t addr) >>> struct gpe_regs *g = opaque; >>> switch (addr) { >>> case PROC_BASE: >>> - val = g->up; >>> - break; >>> case PROC_BASE + 1: >>> - val = g->down; >>> + val = gpe_read_val(g->cpus_sts, addr); >>> + break; >>> + case PROC_BASE + 2: >>> + case PROC_BASE + 3: >>> + val = gpe_read_val(g->bios_cpus_sts, addr); >>> break; >>> >>> >> Why can't the bios maintain bios_cpu_sts in RAM? >> >> > It can, just need to find a place for it. Currently our AML does not use > RAM at all. OperationRegion(..., SystemMemory, ...) should work. It's better to avoid introducing unnecessary virtual hardware. -- error compiling committee.c: too many arguments to function