From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [maint/2.6.29 PATCH] kvm-userspace: include on external-module-compat.h Date: Wed, 04 Feb 2009 16:27:47 +0200 Message-ID: <4989A5E3.2060604@redhat.com> References: <1232744383-998-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51799 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbZBDO1u (ORCPT ); Wed, 4 Feb 2009 09:27:50 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n14ERoHb019813 for ; Wed, 4 Feb 2009 09:27:50 -0500 In-Reply-To: <1232744383-998-1-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > Make sure we get the MSR_* defines from asm/svm.h before checking > if they are defined. > > This fixes the following warning: > > In file included from /home/ehabkost/code/kvm/kvm-userspace/kernel/x86/kvm_svm.h:10, > from /home/ehabkost/code/kvm/kvm-userspace/kernel/x86/svm.c:58: > /home/ehabkost/code/kvm/kvm-userspace/kernel/include/asm/svm.h:219:1: warning: "MSR_VM_HSAVE_PA" redefined > > > This fix applies only to the maint/2.6.29 branch, as on the master > branch the MSR_* defines went to a different header file. > I fixed this on master with d3898e3aaef791fac527d4cf4fc5b898887abc38. Any reason not to apply the same fix to maint? -- error compiling committee.c: too many arguments to function