From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] External module compatibility for hrtimer_expires_remaining Date: Wed, 04 Feb 2009 17:17:06 +0100 Message-ID: <4989BF82.6030403@suse.de> References: <1232654745-17842-1-git-send-email-agraf@suse.de> <4978E303.4000801@suse.de> <4989A902.7080600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from ns2.suse.de ([195.135.220.15]:37904 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbZBDQRI (ORCPT ); Wed, 4 Feb 2009 11:17:08 -0500 In-Reply-To: <4989A902.7080600@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Alexander Graf wrote: >> Alexander Graf wrote: >>> Due to Marcelo's APIC fix we now depend on hrtimer_expires_remainin= g, >>> which is not available on my 2.6.27 kernel. >>> >>> This patch adds a backwards compatibility layer for it. >>> >>> Signed-off-by: Alexander Graf >> >> I just saw that you did one yourself that doesn't work for me. Is th= e >> #define reversed? > > See also my change to hack-module.awk. Did you 'make sync' again? On a freshly git pull'ed checkout with a 2.6.27 host kernel: /dev/shm/x/kvm-userspace/kernel/x86/lapic.c: In function =91apic_get_tm= cct=92: /dev/shm/x/kvm-userspace/kernel/x86/lapic.c:570: error: implicit declaration of function =91hrtimer_expires_remaining=92 /dev/shm/x/kvm-userspace/kernel/x86/lapic.c:570: error: incompatible types in assignment I'd say the problem is the #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,27) which should be 2.6.28, right? Alex