From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] External module compatibility for hrtimer_expires_remaining Date: Wed, 04 Feb 2009 19:19:43 +0200 Message-ID: <4989CE2F.90007@redhat.com> References: <1232654745-17842-1-git-send-email-agraf@suse.de> <4978E303.4000801@suse.de> <4989A902.7080600@redhat.com> <4989BF82.6030403@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49169 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbZBDRTw (ORCPT ); Wed, 4 Feb 2009 12:19:52 -0500 In-Reply-To: <4989BF82.6030403@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > Avi Kivity wrote: > =20 >> Alexander Graf wrote: >> =20 >>> Alexander Graf wrote: >>> =20 >>>> Due to Marcelo's APIC fix we now depend on hrtimer_expires_remaini= ng, >>>> which is not available on my 2.6.27 kernel. >>>> >>>> This patch adds a backwards compatibility layer for it. >>>> >>>> Signed-off-by: Alexander Graf >>>> =20 >>> I just saw that you did one yourself that doesn't work for me. Is t= he >>> #define reversed? >>> =20 >> See also my change to hack-module.awk. Did you 'make sync' again? >> =20 > > On a freshly git pull'ed checkout with a 2.6.27 host kernel: > > /dev/shm/x/kvm-userspace/kernel/x86/lapic.c: In function =91apic_get_= tmcct=92: > /dev/shm/x/kvm-userspace/kernel/x86/lapic.c:570: error: implicit > declaration of function =91hrtimer_expires_remaining=92 > /dev/shm/x/kvm-userspace/kernel/x86/lapic.c:570: error: incompatible > types in assignment > > I'd say the problem is the > > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,27) > > which should be 2.6.28, right? > =20 You're right -- will fix. --=20 error compiling committee.c: too many arguments to function