From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] kvm: fix circular locking dependency Date: Sun, 08 Feb 2009 11:43:46 +0200 Message-ID: <498EA952.5040508@redhat.com> References: <1233678929.3726.48.camel@blaa> <1233858226-21181-1-git-send-email-markmc@redhat.com> <20090205185234.GC27684@sequoia.sous-sol.org> <1233910651.3673.43.camel@blaa> <20090208052805.GA4437@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark McLoughlin , Chris Wright , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58244 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbZBHJnu (ORCPT ); Sun, 8 Feb 2009 04:43:50 -0500 In-Reply-To: <20090208052805.GA4437@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Fri, Feb 06, 2009 at 08:57:31AM +0000, Mark McLoughlin wrote: > >> On Thu, 2009-02-05 at 10:52 -0800, Chris Wright wrote: >> >>> * Mark McLoughlin (markmc@redhat.com) wrote: >>> >>>> kvm->slots_lock is outer to kvm->lock, so take slots_lock >>>> in kvm_vm_ioctl_assign_device() before taking kvm->lock, >>>> rather than taking it in kvm_iommu_map_memslots(). >>>> Applied, but, >>> stable? maint/2.6.29? >>> >> Yep, my bad - Avi, please add: >> >> Cc: stable@kernel.org >> >> and pull into maint/2.6.29 >> > > ACK. > > At this point in maint/2.6.29's lifetime, it gets updated by pulling from Linus, and stable is only updated after Linus is updated. (It's the same rule, really -- only commit to a maintenance branch after upstream has been fixed, to ensure we don't have a maint fix without a corresponding upstream fix) -- error compiling committee.c: too many arguments to function