From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH] Fix warnings in virtio-net Date: Mon, 09 Feb 2009 10:17:29 +0100 Message-ID: <498FF4A9.40809@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit To: kvm-devel Return-path: Received: from gecko.sbs.de ([194.138.37.40]:22748 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbZBIJRc (ORCPT ); Mon, 9 Feb 2009 04:17:32 -0500 Received: from mail1.sbs.de (localhost [127.0.0.1]) by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n199HUkb020368 for ; Mon, 9 Feb 2009 10:17:30 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n199HUun005790 for ; Mon, 9 Feb 2009 10:17:30 +0100 Sender: kvm-owner@vger.kernel.org List-ID: Those void returns are bogus, but there is no need to check for allocation failures anyway. Signed-off-by: Jan Kiszka diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c index f125edc..35f66d7 100644 --- a/qemu/hw/virtio-net.c +++ b/qemu/hw/virtio-net.c @@ -692,12 +692,8 @@ PCIDevice *virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn) n->promisc = 1; /* for compatibility */ n->mac_table.macs = qemu_mallocz(MAC_TABLE_ENTRIES * ETH_ALEN); - if (!n->mac_table.macs) - return; n->vlans = qemu_mallocz(MAX_VLAN >> 3); - if (!n->vlans) - return; register_savevm("virtio-net", virtio_net_id++, VIRTIO_NET_VM_VERSION, virtio_net_save, virtio_net_load, n);