From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device Date: Wed, 11 Feb 2009 14:48:55 +0200 Message-ID: <4992C937.2090708@redhat.com> References: <1234339731-3195-1-git-send-email-sheng@linux.intel.com> <1234339731-3195-4-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52922 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbZBKMs7 (ORCPT ); Wed, 11 Feb 2009 07:48:59 -0500 In-Reply-To: <1234339731-3195-4-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > This patch finally enable MSI-X. > > What we need for MSI-X: > 1. Intercept one page in MMIO region of device. So that we can get guest desired > MSI-X table and set up the real one. Now this have been done by guest, and > transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY. > > Looking at the patch, you're doing that in userspace. Good. > 2. The PCI spec allowed to change MSI-X table dynamically. That means, the OS > can enable MSI-X, then mask one MSI-X entry, modify it, and unmask it. The patch > didn't support this, and Linux also don't work in this way. > What about Windows? -- error compiling committee.c: too many arguments to function