From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] Fix kvmclock on !constant_tsc boxes.
Date: Wed, 11 Feb 2009 15:14:48 +0200 [thread overview]
Message-ID: <4992CF48.7080206@redhat.com> (raw)
In-Reply-To: <20090209201504.GA10603@amt.cnet>
Marcelo Tosatti wrote:
> On Sun, Feb 08, 2009 at 04:08:56AM -0200, Marcelo Tosatti wrote:
>
>> On Wed, Feb 04, 2009 at 05:52:04PM +0100, Gerd Hoffmann wrote:
>>
>>> Hi folks,
>>>
>>> kvmclock currently falls apart on machines without constant tsc.
>>> This patch fixes it. Changes:
>>>
>>> * keep tsc frequency in a per-cpu variable.
>>> * handle kvmclock update using a new request flag, thus checking
>>> whenever we need an update each time we enter guest context.
>>> * use a cpufreq notifier to track frequency changes and force
>>> kvmclock updates.
>>> * send ipis to kick cpu out of guest context if needed to make
>>> sure the guest doesn't see stale values.
>>>
>>> cheers,
>>> Gerd
>>>
>> ACK for 2.6.29 (but please fix the whitespace breakage).
>>
>
> Whitespace fixed version attached.
>
>
Applied, thanks (together with a revert of the commit that disables
kvmclock on !constant_tsc).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-02-11 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 16:52 [PATCH] Fix kvmclock on !constant_tsc boxes Gerd Hoffmann
2009-02-07 7:14 ` Marcelo Tosatti
2009-02-08 6:08 ` Marcelo Tosatti
2009-02-09 20:15 ` Marcelo Tosatti
2009-02-11 13:14 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4992CF48.7080206@redhat.com \
--to=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox