From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix kvmclock on !constant_tsc boxes. Date: Wed, 11 Feb 2009 15:14:48 +0200 Message-ID: <4992CF48.7080206@redhat.com> References: <4989C7B4.10508@redhat.com> <20090208060856.GC4437@amt.cnet> <20090209201504.GA10603@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , KVM list To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60574 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753467AbZBKNOw (ORCPT ); Wed, 11 Feb 2009 08:14:52 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1BDEpxv007402 for ; Wed, 11 Feb 2009 08:14:51 -0500 In-Reply-To: <20090209201504.GA10603@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Sun, Feb 08, 2009 at 04:08:56AM -0200, Marcelo Tosatti wrote: > >> On Wed, Feb 04, 2009 at 05:52:04PM +0100, Gerd Hoffmann wrote: >> >>> Hi folks, >>> >>> kvmclock currently falls apart on machines without constant tsc. >>> This patch fixes it. Changes: >>> >>> * keep tsc frequency in a per-cpu variable. >>> * handle kvmclock update using a new request flag, thus checking >>> whenever we need an update each time we enter guest context. >>> * use a cpufreq notifier to track frequency changes and force >>> kvmclock updates. >>> * send ipis to kick cpu out of guest context if needed to make >>> sure the guest doesn't see stale values. >>> >>> cheers, >>> Gerd >>> >> ACK for 2.6.29 (but please fix the whitespace breakage). >> > > Whitespace fixed version attached. > > Applied, thanks (together with a revert of the commit that disables kvmclock on !constant_tsc). -- error compiling committee.c: too many arguments to function