From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dor Laor Subject: Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change Date: Sun, 15 Feb 2009 00:28:49 +0200 Message-ID: <499745A1.3040707@redhat.com> References: <20090211070049.GA27821@shareable.org> <49955681.9070301@suse.de> <20090213162336.GI18471@shareable.org> Reply-To: dlaor@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jamie Lokier , qemu-devel@nongnu.org, Gleb Natapov , kvm@vger.kernel.org To: Marc Bevand Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43205 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbZBNW2g (ORCPT ); Sat, 14 Feb 2009 17:28:36 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Marc Bevand wrote: > On Fri, Feb 13, 2009 at 8:23 AM, Jamie Lokier wrote: > >> Marc.. this is quite a serious bug you've reported. Is there a >> reason you didn't report it earlier? >> > > Because I only started hitting that bug a couple weeks ago after > having upgraded to a buggy kvm version. > > >> Is there a way to restructure the code and/or how it works so it's >> more clearly correct? >> > > I am seriously concerned about the general design of qcow2. The code > base is more complex than it needs to be, the format itself is > susceptible to race conditions causing cluster leaks when updating > some internal datastructures, it gets easily fragmented, etc. > > I am considering implementing a new disk image format that supports > base images, snapshots (of the guest state), clones (of the disk > content); that has a radically simpler design & code base; that is > always consistent "on disk"; that is friendly to delta diffing (ie. > space-efficient when used with ZFS snapshots or rsync); and that makes > use of checksumming & replication to detect & fix corruption of > critical data structures (ideally this should be implemented by the > filesystem, unfortunately ZFS is not available everywhere :D). > > I believe the key to achieve these (seemingly utopian) goals is to > represent a disk "image" as a set of sparse files, 1 per > snapshot/clone. > Both qcow2 and vmdk have the ability to keep 'external' snapshots. In addition to what you wrote, qcow2 is missing journal for its meta data and also performs poorly because of complex meta data and sync calls. We might use vmdk format or VHD as a base for the future high performing, safe image format for qemu -dor > -marc > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >