From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin Subject: [PATCH] kvm: ||/&& typo Date: Tue, 17 Feb 2009 15:49:15 +0100 Message-ID: <499ACE6B.6020407@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, jvpeetz@web.de, Andrew Morton To: avi@redhat.com Return-path: Received: from mail-bw0-f161.google.com ([209.85.218.161]:49130 "EHLO mail-bw0-f161.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbZBQOtS (ORCPT ); Tue, 17 Feb 2009 09:49:18 -0500 Received: by bwz5 with SMTP id 5so4143112bwz.13 for ; Tue, 17 Feb 2009 06:49:16 -0800 (PST) Sender: kvm-owner@vger.kernel.org List-ID: This was also reported by J=F6rg-Volker Peetz here: http://lkml.org/lkml/2009/2/16/325 ------------------->8---------------------8<----------------------- Since ss.type is always either not 3 or not 7. Signed-off-by: Roel Kluin --- diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6259d74..7c4cca1 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1813,7 +1813,7 @@ static bool stack_segment_valid(struct kvm_vcpu *= vcpu) vmx_get_segment(vcpu, &ss, VCPU_SREG_SS); ss_rpl =3D ss.selector & SELECTOR_RPL_MASK; =20 - if ((ss.type !=3D 3) || (ss.type !=3D 7)) + if ((ss.type !=3D 3) && (ss.type !=3D 7)) return false; if (!ss.s) return false;