From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X
Date: Tue, 17 Feb 2009 18:09:49 +0000 [thread overview]
Message-ID: <499AFD6D.5090607@redhat.com> (raw)
In-Reply-To: <200902131137.47240.sheng@linux.intel.com>
Sheng Yang wrote:
>>> + if (assigned_dev->irq_requested_type == KVM_ASSIGNED_DEV_MSIX) {
>>> + u32 gsi;
>>> + gsi = find_gsi_from_host_irq(assigned_dev, irq);
>>> + if (gsi == 0)
>>> + return IRQ_HANDLED;
>>>
>> So you chose GSI == 0 as invalid because of x86 assumptions? Or is there
>> any other reason?
>>
>
> Yeah, it based on x86 and IA64 IRQ 0 can't be used by MSI-X. And only x86
> support MSI-X now(and IA64 would follow later).
>
gsi != irq... as used in kvm it is just a cookie and is never visible to
the guest. I'd prefer an illegal value here.
Also, please repost the entire patchset so I can be sure I apply the
latest; too many versions floating around.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-02-17 18:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 8:08 [PATCH 0/3 v2] MSI-X enabling Sheng Yang
2009-02-11 8:08 ` [PATCH 1/3] KVM: Ioctls for init MSI-X entry Sheng Yang
2009-02-11 12:44 ` Avi Kivity
2009-02-12 6:28 ` Sheng Yang
2009-02-12 10:07 ` Sheng Yang
2009-02-12 18:46 ` Marcelo Tosatti
2009-02-16 3:18 ` Sheng Yang
2009-02-16 5:49 ` Sheng Yang
2009-02-16 23:23 ` Marcelo Tosatti
2009-02-17 1:35 ` Sheng Yang
2009-02-17 1:36 ` Sheng Yang
2009-02-11 8:08 ` [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X Sheng Yang
2009-02-12 19:51 ` Marcelo Tosatti
2009-02-13 3:37 ` Sheng Yang
2009-02-13 17:10 ` Marcelo Tosatti
2009-02-17 18:09 ` Avi Kivity [this message]
2009-02-18 1:33 ` Sheng Yang
2009-02-11 8:08 ` [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device Sheng Yang
2009-02-11 12:48 ` Avi Kivity
2009-02-12 6:03 ` Sheng Yang
2009-02-12 20:40 ` Marcelo Tosatti
2009-02-13 5:29 ` Sheng Yang
2009-02-13 17:13 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2009-02-18 9:44 [PATCH 0/3 v3] MSI-X enabling Sheng Yang
2009-02-18 9:44 ` [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X Sheng Yang
2009-02-18 11:00 ` Avi Kivity
2009-02-18 11:13 ` Sheng Yang
2009-02-18 11:29 ` Avi Kivity
2009-02-18 11:38 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499AFD6D.5090607@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox