From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: userspace: Initialise ECX value with 'count' as host_cpuid now expects it Date: Tue, 17 Feb 2009 18:11:55 +0000 Message-ID: <499AFDEB.8080603@redhat.com> References: <1234885535-8332-1-git-send-email-amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35465 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbZBQSL0 (ORCPT ); Tue, 17 Feb 2009 13:11:26 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1HIBQVb008888 for ; Tue, 17 Feb 2009 13:11:26 -0500 In-Reply-To: <1234885535-8332-1-git-send-email-amit.shah@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > host_cpuid now accepts a 'count' parameter for cpuid. Initialise the value > of ecx before any call to the function. > > Signed-off-by: Amit Shah > --- > qemu/qemu-kvm-x86.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c > index 5264015..b1e2da2 100644 > --- a/qemu/qemu-kvm-x86.c > +++ b/qemu/qemu-kvm-x86.c > @@ -534,6 +534,7 @@ int kvm_arch_qemu_init_env(CPUState *cenv) > #endif > > copy.regs[R_EAX] = 0; > + copy.regs[R_ECX] = 0; > qemu_kvm_cpuid_on_env(©); > limit = copy.regs[R_EAX]; > > @@ -559,6 +560,7 @@ int kvm_arch_qemu_init_env(CPUState *cenv) > } > > copy.regs[R_EAX] = 0x80000000; > + copy.regs[R_ECX] = 0; > qemu_kvm_cpuid_on_env(©); > limit = copy.regs[R_EAX]; > Does this make any difference? Neither function actually depends on ecx. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.