From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X Date: Wed, 18 Feb 2009 11:29:28 +0000 Message-ID: <499BF118.3060703@redhat.com> References: <1234950262-4142-1-git-send-email-sheng@linux.intel.com> <1234950262-4142-3-git-send-email-sheng@linux.intel.com> <499BEA65.8060902@redhat.com> <200902181913.22815.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56334 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbZBRL27 (ORCPT ); Wed, 18 Feb 2009 06:28:59 -0500 In-Reply-To: <200902181913.22815.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > On Wednesday 18 February 2009 19:00:53 Avi Kivity wrote: > >> Sheng Yang wrote: >> >>> We have to handle more than one interrupt with one handler for MSI-X. So >>> we need a bitmap to track the triggered interrupts. >>> >> Can you explain why? >> > > Or how can we know which interrupt happened? Current we scheduled the work > later, and no more irq information available at that time. > We can have a work_struct per interrupt, or we can set a flag in the msix array that the interrupt is pending. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.