From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/7] [V3] kvm: qemu: fix hot remove assigned device with iommu Date: Wed, 18 Feb 2009 12:38:04 +0000 Message-ID: <499C012C.1040803@redhat.com> References: <715D42877B251141A38726ABF5CABF2C01959AFEBC@pdsmsx503.ccr.corp.intel.com> <20090218014837.GC17925@amt.cnet> <715D42877B251141A38726ABF5CABF2C0195848DFD@pdsmsx503.ccr.corp.intel.com> <715D42877B251141A38726ABF5CABF2C0195A1F7BD@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "'Marcelo Tosatti'" , "'kvm@vger.kernel.org'" , "'Mark McLoughlin'" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42843 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbZBRMhg (ORCPT ); Wed, 18 Feb 2009 07:37:36 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C0195A1F7BD@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: > device assignment hotplug doesn't work on current tree. I had a quick glance, found device assignment didn't be considered, qemu_system_hot_assign_device is not used at all. I will fix it. > I noticed that during the merge, but wasn't familiar in the code to fix it myself. Thanks for taking care of it. We should work to merge the code in upstream qemu so that this doesn't happen again. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.