From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] kvm: bios: make MMIO address page aligned in guest Date: Tue, 24 Feb 2009 12:43:24 +0200 Message-ID: <49A3CF4C.2010601@redhat.com> References: <715D42877B251141A38726ABF5CABF2C0195A1FE52@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "'kvm@vger.kernel.org'" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54625 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbZBXKn2 (ORCPT ); Tue, 24 Feb 2009 05:43:28 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C0195A1FE52@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: > MMIO of some devices are not page aligned, such as some EHCI > controllers and virtual Realtek NIC in guest. Current guest > bios doesn't guarantee the start address of MMIO page aligned. > This may result in failure of device assignment, because KVM > only allow to register page aligned memory slots. For example, > it fails to assign EHCI controller (its MMIO size is 1KB) with > virtual Realtek NIC (its MMIO size is 256Bytes), because MMIO > of virtual Realtek NIC in guest starts from 0xf2001000, MMIO of > the EHCI controller will starts from 0xf2001400. > > MMIO addresses in guest are allocated in guest bios. This patch > makes MMIO address page aligned in bios, then fixes the issue. > > Applied, thanks. -- error compiling committee.c: too many arguments to function