Re: [PATCH 1/1] kvm: bios: make MMIO address page aligned in guest

[Anthony Liguori <anthony@codemonkey.ws>]

Avi Kivity wrote:
> Han, Weidong wrote:
>> MMIO of some devices are not page aligned, such as some EHCI
>> controllers and virtual Realtek NIC in guest. Current guest
>> bios doesn't guarantee the start address of MMIO page aligned.
>> This may result in failure of device assignment, because KVM
>> only allow to register page aligned memory slots. For example,
>> it fails to assign EHCI controller (its MMIO size is 1KB) with
>> virtual Realtek NIC (its MMIO size is 256Bytes), because MMIO
>> of virtual Realtek NIC in guest starts from 0xf2001000, MMIO of
>> the EHCI controller will starts from 0xf2001400.
>>
>> MMIO addresses in guest are allocated in guest bios. This patch
>> makes MMIO address page aligned in bios, then fixes the issue.
>>
>>   
>
> Applied, thanks.

I think this patch could also be sent to upstream QEMU/bochs-devel.  
Even though neither supports device assignment right now, QEMU 
eventually will and it seems like a sane thing to do anyway.

Regards,

Anthony Liguori