From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: KVM: x86: silence preempt warning on kvm_write_guest_time
Date: Wed, 25 Feb 2009 11:40:55 +0100
Message-ID: <49A52037.8000808@redhat.com>
References: <20090224182800.GA7653@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	Glauber de Oliveira Costa <gcosta@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:37688 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755020AbZBYKlA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Feb 2009 05:41:00 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1PAex81007029
	for <kvm@vger.kernel.org>; Wed, 25 Feb 2009 05:40:59 -0500
In-Reply-To: <20090224182800.GA7653@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> See comments on
> http://sourceforge.net/tracker2/?func=detail&aid=2627272&group_id=180599&atid=893831
> regarding the "version" variable. Looks fishy.

Fix looks correct (for both per-cpu access and the version stuff).

I think prempting the vcpu to another pcpu will force a kvmclock update,
so this should be handled just fine already.

cheers,
  Gerd