From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm: declare kvm_ioapic in kvm_host.h
Date: Thu, 26 Feb 2009 14:43:54 +0200
Message-ID: <49A68E8A.7040404@redhat.com>
References: <1235553536-32690-1-git-send-email-sheng@linux.intel.com> <200902261339.36237.borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Sheng Yang <sheng@linux.intel.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:46772 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753046AbZBZMo0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 26 Feb 2009 07:44:26 -0500
In-Reply-To: <200902261339.36237.borntraeger@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Christian Borntraeger wrote:
> With todays git I get the following warnings on s390:
>
>   CC [M]  arch/s390/kvm/kvm-s390.o
> In file included from arch/s390/kvm/kvm-s390.c:22:
> include/linux/kvm_host.h:357: warning: 'struct kvm_ioapic' declared inside parameter list
> include/linux/kvm_host.h:357: warning: its scope is only this definition or declaration, which is probably not what you want
> [...]
>
> Declaring struct kvm_ioapic should help.
>
>   

Better to limit the declaration to archs that have ioapics... do we have 
a KVM_HAVE_IOAPIC define?

-- 
error compiling committee.c: too many arguments to function