Re: [PATCH] kvm: external module: support building against Windriver 2.0 (kernel 2.6.21)

[Avi Kivity <avi@redhat.com>]

Jan Kiszka wrote:
> Bernhard Kohl wrote:
>   
>> This is needed to compile kvm in a Windriver 2.0 distribution
>> (kernel 2.6.21). This kernel has an include file marker.h, but
>> trace_mark is not defined there. So the compat code in
>> kernel/include-compat/linux/marker.h is not included.
>>     
>
> I bet this is because Wind River patched some variant of LTTng into
> their kernel.
>
> However, I'm unsure if supporting significantly modified distribution
> kernels is in the scope of this compat layer. 

Yes, for example we support the RHEL 5 series, which significantly 
deviates from plain 2.6.18.

> If it is ok for the
> maintainers, you should try to make the test more Wind River specific
> (did you check that there is no side-effect for normal <= 2.6.21
> kernels?) and maybe add a comment.
>   

Best would be to check for a Wind River kernel as this is likely to 
break on mainline Linux.



-- 
error compiling committee.c: too many arguments to function