From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] do not free active mmu pages in free_mmu_pages() Date: Sun, 15 Mar 2009 14:59:41 +0200 Message-ID: <49BCFBBD.3080805@redhat.com> References: <20090311100755.GA19724@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: marcelo@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45415 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbZCOM7o (ORCPT ); Sun, 15 Mar 2009 08:59:44 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2FCxhM4017006 for ; Sun, 15 Mar 2009 08:59:43 -0400 In-Reply-To: <20090311100755.GA19724@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > free_mmu_pages() should only undo what alloc_mmu_pages() does. > > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 2a36f7f..b625ed4 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -2638,14 +2638,6 @@ EXPORT_SYMBOL_GPL(kvm_disable_tdp); > > static void free_mmu_pages(struct kvm_vcpu *vcpu) > { > - struct kvm_mmu_page *sp; > - > - while (!list_empty(&vcpu->kvm->arch.active_mmu_pages)) { > - sp = container_of(vcpu->kvm->arch.active_mmu_pages.next, > - struct kvm_mmu_page, link); > - kvm_mmu_zap_page(vcpu->kvm, sp); > - cond_resched(); > - } > free_page((unsigned long)vcpu->arch.mmu.pae_root); > } > > I think this is correct, but the patch leaves the function name wrong. Rename, or perhaps just open code into callers? -- error compiling committee.c: too many arguments to function