From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/16 v5] Device assignment improvement in userspace Date: Mon, 16 Mar 2009 11:10:47 +0200 Message-ID: <49BE1797.4010305@redhat.com> References: <1236865019-30321-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Anthony Liguori , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55721 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbZCPJKw (ORCPT ); Mon, 16 Mar 2009 05:10:52 -0400 In-Reply-To: <1236865019-30321-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Patch 1 and 2 are new ones, all the others had been sent before. > > This (huge) patchset, contained: > > Patch 1..2 are new interface after reworked device assignment kernel part. > > Patch 3..6 are generic capability support mechanism. These may can be adopted > by QEmu upstream as well. > > Patch 7..10 enable MSI with device assignment on KVM. Also due to reworked > device assignment kernel part discard MSI convert to INTx mechanism, patch 10 > enable it again in userspace. > > Patch 11..13 enable MSI-X with device assignment on KVM. > > And Patch 14..16 enable SR-IOV with KVM. > > Update from latest series: > > 1. Convert to the new ioctl interface. > 2. Merge capability configuration space with PCIDevice one. > 3. Support of deassign IRQ(unload driver) with MSI/MSI-X better. > 4. Not assume IRQ0 means no INTx any longer, but check interrupt pin field in > configuration space for the judgment. > > Please help to review! Thanks! > This looks ready to apply. I'd like Marcelo to look it over, though, before. -- error compiling committee.c: too many arguments to function