From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Device assignment framework rework Date: Mon, 16 Mar 2009 11:23:42 +0200 Message-ID: <49BE1A9E.3010204@redhat.com> References: <1236865539-30553-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58243 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbZCPJXp (ORCPT ); Mon, 16 Mar 2009 05:23:45 -0400 In-Reply-To: <1236865539-30553-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > After discussion with Marcelo, we decided to rework device assignment framework > together. The old problems are kernel logic is unnecessary complex. So Marcelo > suggest to split it into a more elegant way: > > 1. Split host IRQ assign and guest IRQ assign. And userspace determine the > combination. Also discard msi2intx parameter, userspace can specific > KVM_DEV_IRQ_HOST_MSI | KVM_DEV_IRQ_GUEST_INTX in assigned_irq->flags to > enable MSI to INTx convertion. > > 2. Split assign IRQ and deassign IRQ. Import two new ioctls: > KVM_ASSIGN_DEV_IRQ and KVM_DEASSIGN_DEV_IRQ. > > This patch also fixed the reversed _IOR vs _IOW in definition(by deprecated the > old interface). > > Applied, thanks. I replaced bitcount() by the standard hweight_long(). -- error compiling committee.c: too many arguments to function