From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-userspace: x86: Support for breakpoints in ROM code Date: Tue, 17 Mar 2009 11:33:41 +0200 Message-ID: <49BF6E75.1070802@redhat.com> References: <49BE9EF7.7010005@siemens.com> <49BEA02A.1070909@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([66.187.233.31]:56135 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbZCQJdq (ORCPT ); Tue, 17 Mar 2009 05:33:46 -0400 In-Reply-To: <49BEA02A.1070909@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Jan Kiszka wrote: > >> Align qemu-kvm-x86 with upstream kvm support /wrt software breakpoint >> support in ROM code. >> > > Hmm, this might not be needed as kvm-userspace is not protecting its > ROM. That's why I didn't pushed this so far. However, aligning isn't > bad. But dropping this duplication would be better... > Aligning is a good thing (and duplication can be fixed in upstream and merged here). But maybe cpu_memory_rw_debug() should use cpu_physical_memory_write_rom() to write, instead of this hack? -- error compiling committee.c: too many arguments to function