From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
"Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH 1/2] Timer event should not unconditionally unhalt vcpu.
Date: Mon, 23 Mar 2009 16:26:34 +0200 [thread overview]
Message-ID: <49C79C1A.6080102@redhat.com> (raw)
In-Reply-To: <20090323131144.GH25518@redhat.com>
Gleb Natapov wrote:
> On Mon, Mar 23, 2009 at 12:12:06PM +0200, Gleb Natapov wrote:
>
>> Currently timer events are processed before entering guest mode. Move it
>> to main vcpu event loop since timer events should be processed even while
>> vcpu is haled. Timer may cause interrupt/nmi to be injected and only then
>> vcpu will be unhalted.
>>
>>
> Use this one instead. Previous broke -no-kvm-irqchip option.
>
Looks good to me. But this is tricky code. Marcelo, Sheng, your opinions?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-23 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 10:12 [PATCH 1/2] Timer event should not unconditionally unhalt vcpu Gleb Natapov
2009-03-23 10:12 ` [PATCH 2/2] Interrupt unhalts vcpu when it shouldn't Gleb Natapov
2009-03-23 14:31 ` Avi Kivity
2009-03-23 15:17 ` Avi Kivity
2009-03-24 5:24 ` Sheng Yang
2009-03-24 10:13 ` Avi Kivity
2009-03-23 13:11 ` [PATCH 1/2] Timer event should not unconditionally unhalt vcpu Gleb Natapov
2009-03-23 14:26 ` Avi Kivity [this message]
2009-03-23 16:50 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C79C1A.6080102@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox