From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] Timer event should not unconditionally unhalt vcpu. Date: Mon, 23 Mar 2009 16:26:34 +0200 Message-ID: <49C79C1A.6080102@redhat.com> References: <20090323101205.25798.69237.stgit@dhcp-1-237.tlv.redhat.com> <20090323131144.GH25518@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , "Yang, Sheng" To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39559 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116AbZCWO0i (ORCPT ); Mon, 23 Mar 2009 10:26:38 -0400 In-Reply-To: <20090323131144.GH25518@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > On Mon, Mar 23, 2009 at 12:12:06PM +0200, Gleb Natapov wrote: > >> Currently timer events are processed before entering guest mode. Move it >> to main vcpu event loop since timer events should be processed even while >> vcpu is haled. Timer may cause interrupt/nmi to be injected and only then >> vcpu will be unhalted. >> >> > Use this one instead. Previous broke -no-kvm-irqchip option. > Looks good to me. But this is tricky code. Marcelo, Sheng, your opinions? -- error compiling committee.c: too many arguments to function