From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Subject: Re: Kernel GPF in vmx_save_host_state()
Date: Mon, 23 Mar 2009 14:24:24 -0400
Message-ID: <49C7D3D8.3060508@cs.cmu.edu>
References: <49C0313C.5010906@cs.cmu.edu> <49C0B702.1060807@redhat.com> <49C12ED2.4080209@cs.cmu.edu> <49C20ED4.2040700@redhat.com> <49C2B289.7030707@cs.cmu.edu> <49C60011.8030405@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from JACKFRUIT.SRV.CS.CMU.EDU ([128.2.201.16]:45116 "EHLO
	jackfruit.srv.cs.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754080AbZCWSyK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Mar 2009 14:54:10 -0400
In-Reply-To: <49C60011.8030405@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> On 32-bit, we might actually reach the default: label of the switch in 
> vmx_set_msr().  Can you add a printk() there? print both msr_index, and, 
> if msr is not NULL, msr->index and msr->data.

Sure:

vmx_set_msr: msr_index 0xc0000081 msr->index 0xc0000081 msr->data 0x0
vmx_set_msr: msr_index 0xc0010117
vmx_set_msr: msr_index 0x250
vmx_set_msr: msr_index 0x258
vmx_set_msr: msr_index 0x259
vmx_set_msr: msr_index 0x268
vmx_set_msr: msr_index 0x269
vmx_set_msr: msr_index 0x26a
vmx_set_msr: msr_index 0x26b
vmx_set_msr: msr_index 0x26c
vmx_set_msr: msr_index 0x26d
vmx_set_msr: msr_index 0x26e
vmx_set_msr: msr_index 0x26f
vmx_set_msr: msr_index 0x200
vmx_set_msr: msr_index 0x201
vmx_set_msr: msr_index 0x2ff
vmx_set_msr: msr_index 0xc0000080 msr->index 0xc0000080 msr->data 0x100
general protection fault: 0000 [#1] PREEMPT SMP
[...]

The printk is after msr->data is set to the value of the data parameter.

--Benjamin Gilbert