From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm: external module: do not hardcode tsc_khz Date: Tue, 24 Mar 2009 11:36:13 +0200 Message-ID: <49C8A98D.4030600@redhat.com> References: <20090323174643.GA28963@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33390 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755257AbZCXJgZ (ORCPT ); Tue, 24 Mar 2009 05:36:25 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2O9aNCu020028 for ; Tue, 24 Mar 2009 05:36:23 -0400 In-Reply-To: <20090323174643.GA28963@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > external module compat hard codes tsc_khz as 2000000 if KERNEL_VERSION < > (2,6,23). > > This breaks kvmclock on hosts with different frequency. > > While tsc_khz was only exported on 2.6.23, the majority of relevant > older v2.6 based distros seem to have it exported. > Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.