From: Avi Kivity <avi@redhat.com>
To: Yaniv Kamay <ykamay@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] fix bad physical address in kvm_update_dirty_pages_log()
Date: Wed, 25 Mar 2009 14:27:07 +0200 [thread overview]
Message-ID: <49CA231B.5040803@redhat.com> (raw)
In-Reply-To: <49C94A2F.9070706@redhat.com>
Yaniv Kamay wrote:
> Hi,
>
> Attaching patch that fix updating qemu dirty region. Previous
> kvm_update_dirty_pages_log() imp treat physical
> ram as if it is linear mapped to guest physical memory. This patch fix
> it by mapping physical ram to guest physical
> memory areas and for etch area call kvm_get_dirty_pages_range() with
> the correct address and size.
>
kvm_get_dirty_pages_range() already operates on guest physical memory,
and kvm_get_dirty_pages_log_range() (which is called by the callback)
translates it to ram_addr, so it should work, no? Maybe change the
range parameters from (0, phys_ram_size) to (0, ~0UL)?
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-03-25 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:01 [PATCH] fix bad physical address in kvm_update_dirty_pages_log() Yaniv Kamay
2009-03-24 21:13 ` Glauber Costa
2009-03-24 21:27 ` Yaniv Kamay
2009-03-24 21:30 ` Glauber Costa
2009-03-25 12:27 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CA231B.5040803@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ykamay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox