From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] fix bad physical address in kvm_update_dirty_pages_log() Date: Wed, 25 Mar 2009 14:27:07 +0200 Message-ID: <49CA231B.5040803@redhat.com> References: <49C94A2F.9070706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Yaniv Kamay Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42165 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760920AbZCYM1L (ORCPT ); Wed, 25 Mar 2009 08:27:11 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2PCRAo6007673 for ; Wed, 25 Mar 2009 08:27:10 -0400 In-Reply-To: <49C94A2F.9070706@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Yaniv Kamay wrote: > Hi, > > Attaching patch that fix updating qemu dirty region. Previous > kvm_update_dirty_pages_log() imp treat physical > ram as if it is linear mapped to guest physical memory. This patch fix > it by mapping physical ram to guest physical > memory areas and for etch area call kvm_get_dirty_pages_range() with > the correct address and size. > kvm_get_dirty_pages_range() already operates on guest physical memory, and kvm_get_dirty_pages_log_range() (which is called by the callback) translates it to ram_addr, so it should work, no? Maybe change the range parameters from (0, phys_ram_size) to (0, ~0UL)? -- error compiling committee.c: too many arguments to function