From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm: qemu: stop/start cpus before/after devices Date: Wed, 25 Mar 2009 16:52:13 +0200 Message-ID: <49CA451D.2060204@redhat.com> References: <20090324171652.GA3655@amt.cnet> <49CA1970.1090509@redhat.com> <20090325142619.GA28345@amt.cnet> <20090325143932.GB28345@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Dor Laor , Yaniv Kamay To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54729 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbZCYOwR (ORCPT ); Wed, 25 Mar 2009 10:52:17 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2PEqGK3007922 for ; Wed, 25 Mar 2009 10:52:16 -0400 In-Reply-To: <20090325143932.GB28345@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Wed, Mar 25, 2009 at 11:26:19AM -0300, Marcelo Tosatti wrote: > >> On Wed, Mar 25, 2009 at 01:45:52PM +0200, Avi Kivity wrote: >> >>> Marcelo Tosatti wrote: >>> >>>> From: Yaniv Kamay >>>> >>>> Stop cpus before devices when stopping the VM, start cpus after devices >>>> when starting VM. >>>> >>>> >>>> >>> Why is this needed? >>> >> A vcpu could access a stopped device otherwise. >> > > Actually on vm_stop its safe because the order happens to be correct, > but on vm_start its the other way around (vcpus start first, and they > should be started last). > Right, applied the patch, thanks. -- error compiling committee.c: too many arguments to function