From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: RFC: Add reserved bits check
Date: Fri, 27 Mar 2009 17:28:05 +0300
Message-ID: <49CCE275.9070608@redhat.com>
References: <9832F13BD22FB94A829F798DA4A8280501A21068EF@pdsmsx503.ccr.corp.intel.com> <9832F13BD22FB94A829F798DA4A8280501A2106E6A@pdsmsx503.ccr.corp.intel.com> <49CC9DAB.8090802@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A2107197@pdsmsx503.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Dong, Eddie" <eddie.dong@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33535 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752810AbZC0O1a (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 27 Mar 2009 10:27:30 -0400
In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501A2107197@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Dong, Eddie wrote:
>> Will never be use, PDPTEs are loaded by set_cr3(), not walk_addr().
>>
>>     
>
> I see, then how about to replace CR3_PAE_RESERVED_BITS check at cr3 load with
> rsvd_bits_mask[2]? Seems current code are lacking of enough reserved bits check too.
>
>   

Need to make sure rsvd_bits_mask[] is maintained on ept and npt, then.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.