public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>
Subject: mm_pages_next() question
Date: Sun, 29 Mar 2009 15:24:08 +0300	[thread overview]
Message-ID: <49CF6868.7040205@redhat.com> (raw)

> static int mmu_pages_next(struct kvm_mmu_pages *pvec,
>                           struct mmu_page_path *parents,
>                           int i)
> {
>         int n;
>
>         for (n = i+1; n < pvec->nr; n++) {
>                 struct kvm_mmu_page *sp = pvec->page[n].sp;
>
>                 if (sp->role.level == PT_PAGE_TABLE_LEVEL) {
>                         parents->idx[0] = pvec->page[n].idx;
>                         return n;
>                 }
>
>                 parents->parent[sp->role.level-2] = sp;
>                 parents->idx[sp->role.level-1] = pvec->page[n].idx;
>         }
>
>         return n;
> }

Do we need to break out of the loop if we switch parents during the loop 
(since that will give us a different mmu_page_path)?  Or are callers 
careful to only pass pvecs which belong to the same shadow page?

-- 
error compiling committee.c: too many arguments to function


             reply	other threads:[~2009-03-29 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29 12:24 Avi Kivity [this message]
2009-03-31 16:18 ` mm_pages_next() question Marcelo Tosatti
2009-04-01  8:40   ` Avi Kivity
2009-04-01 17:15     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CF6868.7040205@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox