From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: mm_pages_next() question
Date: Sun, 29 Mar 2009 15:24:08 +0300
Message-ID: <49CF6868.7040205@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: KVM list <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45227 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751137AbZC2MYL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 29 Mar 2009 08:24:11 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2TCOAxn026145
	for <kvm@vger.kernel.org>; Sun, 29 Mar 2009 08:24:10 -0400
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> static int mmu_pages_next(struct kvm_mmu_pages *pvec,
>                           struct mmu_page_path *parents,
>                           int i)
> {
>         int n;
>
>         for (n = i+1; n < pvec->nr; n++) {
>                 struct kvm_mmu_page *sp = pvec->page[n].sp;
>
>                 if (sp->role.level == PT_PAGE_TABLE_LEVEL) {
>                         parents->idx[0] = pvec->page[n].idx;
>                         return n;
>                 }
>
>                 parents->parent[sp->role.level-2] = sp;
>                 parents->idx[sp->role.level-1] = pvec->page[n].idx;
>         }
>
>         return n;
> }

Do we need to break out of the loop if we switch parents during the loop 
(since that will give us a different mmu_page_path)?  Or are callers 
careful to only pass pvecs which belong to the same shadow page?

-- 
error compiling committee.c: too many arguments to function